Bug: Mismatching type of difficulty_trend in deprecated active_difficulty call

[keerifox]

Summary

difficulty_trend returns a string rather than an array, which caused issues in some wallets relying on it, e.g gonano wallet:

json: cannot unmarshal string into Go struct field .diffulty_trend of type []string

Node version

Nano V22.0

Build details

several community-ran nodes

OS and version

several community-ran nodes

Steps to reproduce the behavior

make an RPC call

{
  "action": "active_difficulty",
  "include_trend": "true"
}

Expected behavior

expected to produce a list as per docs page

Actual behavior

produces an empty string instead

"difficulty_trend": ""

Possible solution

return a single-item list

"difficulty_trend": [
  "1.000000000000000"
]

Supporting files

No response

[shryder]

This RPC command is now marked as deprecated.

[keerifox]

that's what the title of this issue says yes

methods are deprecated to allow to transition away from using them, if there's a breaking change that causes existing integrations to malfunction then it defeats the purpose

[shryder]

My bad, didn't notice it in the title.

[shryder]

Looks like the RPC was completely removed and then got re-added in but now will always send an empty difficulty_trend response (RPC always returns empty string instead of empty array). I can make a pull request to make it send ["1.000000000000000"] back

[zhyatt]

Fixed by #3343