Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPC "active_difficulty" returning empty string as "difficulty_trend" (#3323) #3343

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

shryder
Copy link
Contributor

@shryder shryder commented Jun 16, 2021

No description provided.

@SergiySW SergiySW added the rpc Changes related to Remote Procedure Calls label Jun 16, 2021
@SergiySW
Copy link
Contributor

I guess it will not pass without change here:
https://github.com/nanocurrency/nano-node/blob/develop/nano/rpc_test/rpc.cpp#L7119

@shryder
Copy link
Contributor Author

shryder commented Jun 16, 2021

Yeah I just realized after I made the pull request, looking into it...

@clemahieu clemahieu merged commit baa7f43 into nanocurrency:develop Jun 16, 2021
@shryder shryder deleted the fix_active_difficulty_rpc branch June 20, 2021 17:10
@zhyatt zhyatt added this to the V23.0 milestone Jun 22, 2021
@zhyatt zhyatt added this to Pending testing evaluation in V23.0DB1 via automation Jul 16, 2021
@zhyatt zhyatt moved this from Pending testing evaluation to Pending general testing in V23.0DB1 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Changes related to Remote Procedure Calls
Projects
No open projects
V23.0DB1
Pending general testing
Development

Successfully merging this pull request may close these issues.

Bug: Mismatching type of difficulty_trend in deprecated active_difficulty call
4 participants