Ensure the async_write lambda is a closure around the buffer #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't approve my own pull request ! |
cryptocode
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
LGTM, with this change, some explicit captures in call-sites can probably be removed, like
https://github.com/nanocurrency/raiblocks/blob/5816c25422d066f9877d5cf3271489bd18853891/rai/node/bootstrap.cpp#L430
Since the capture isn't actually used, it's only there to extend the lifetime of the buffer, so the issue was probably known and just missed elsewhere (which this PR fixes for all cases)
clemahieu
reviewed
Sep 25, 2018
|
@clemahieu 👍 That's the first part of the changeset, it just looks like the others so it's easy to miss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.