Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASAN] replace junk data with 0 for peer_put () #1745

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
2 participants
@SergiySW
Copy link
Collaborator

commented Feb 18, 2019

Clang 7.0.0, Ubuntu 18.10

[ RUN      ] block_store.peers
/root/nano_build/lmdb/libraries/liblmdb/mdb.c:7405:19: runtime error: null pointer passed as argument 2, which is declared to never be null
/usr/include/string.h:43:28: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/nano_build/lmdb/libraries/liblmdb/mdb.c:7405:19 in
[       OK ] block_store.peers (8 ms)

@SergiySW SergiySW added the sanitizers label Feb 18, 2019

@SergiySW SergiySW added this to the V18.0 milestone Feb 18, 2019

@SergiySW SergiySW self-assigned this Feb 18, 2019

@SergiySW SergiySW requested a review from wezrule Feb 18, 2019

@SergiySW SergiySW added this to During RC in V18 Feb 18, 2019

@argakiig argakiig self-requested a review Feb 18, 2019

@SergiySW SergiySW merged commit 4e827a2 into nanocurrency:master Feb 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

argakiig added a commit that referenced this pull request Feb 18, 2019

@zhyatt zhyatt moved this from RC2 to RC3 in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.