Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASAN] replace junk data with 0 for peer_put () #1745

Merged
merged 1 commit into from
Feb 18, 2019
Merged

[ASAN] replace junk data with 0 for peer_put () #1745

merged 1 commit into from
Feb 18, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Feb 18, 2019 •
edited
Loading

Clang 7.0.0, Ubuntu 18.10

[ RUN      ] block_store.peers
/root/nano_build/lmdb/libraries/liblmdb/mdb.c:7405:19: runtime error: null pointer passed as argument 2, which is declared to never be null
/usr/include/string.h:43:28: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/nano_build/lmdb/libraries/liblmdb/mdb.c:7405:19 in
[       OK ] block_store.peers (8 ms)

@SergiySW SergiySW added the sanitizers Related to thread, address or undefined sanitizers label Feb 18, 2019
@SergiySW SergiySW added this to the V18.0 milestone Feb 18, 2019
@SergiySW SergiySW self-assigned this Feb 18, 2019
@argakiig argakiig self-requested a review February 18, 2019 19:50
@SergiySW SergiySW merged commit 4e827a2 into nanocurrency:master Feb 18, 2019
argakiig pushed a commit that referenced this pull request Feb 18, 2019
@SergiySW
[ASAN] replace junk data with 0 for peer_put () (#1745)
5f30d5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argakiig argakiig argakiig approved these changes

@wezrule wezrule Awaiting requested review from wezrule

Assignees

@SergiySW SergiySW

Labels
sanitizers Related to thread, address or undefined sanitizers
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SergiySW @argakiig