Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a warning if TSAN/ASAN used together as CMake options #1767

Merged
merged 3 commits into from Feb 25, 2019
Merged

Display a warning if TSAN/ASAN used together as CMake options #1767

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9f1f2c
Display a warning if TSAN/ASAN used together
wezrule Feb 22, 2019
92bef9a
Prioritise ASAN_INT if ASAN is also used
wezrule Feb 22, 2019
84678a6
Display warning if using the sanitizers on Windows
wezrule Feb 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 26 additions & 10 deletions CMakeLists.txt
View file
Open in desktop
Expand Up @@ -30,6 +30,10 @@ endif()

set(CMAKE_POSITION_INDEPENDENT_CODE ON)

set(USING_ASAN (NANO_ASAN OR RAIBLOCKS_ASAN))
set(USING_ASAN_INT (NANO_ASAN_INT OR RAIBLOCKS_ASAN_INT))
set(USING_TSAN (NANO_TSAN OR RAIBLOCKS_TSAN))

find_package(Threads)

if (WIN32)
Expand All @@ -38,15 +42,27 @@ if (WIN32)
-DWIN32_LEAN_AND_MEAN
-DMINIUPNP_STATICLIB
-D_CRT_SECURE_NO_WARNINGS)

if (${USING_TSAN} OR ${USING_ASAN} OR ${USING_ASAN_INT})
message (WARNING "Cannot use TSAN or ASAN on Windows, sanitizers ignored")
endif()

else ()
add_compile_options(-Werror=switch)
if (NANO_ASAN OR RAIBLOCKS_ASAN)
add_compile_options(-fsanitize=address,undefined)
add_definitions(-DED25519_NO_INLINE_ASM)
elseif (NANO_ASAN_INT OR RAIBLOCKS_ASAN_INT)
add_compile_options(-fsanitize=address,undefined,integer)

if ((${USING_TSAN} AND ${USING_ASAN}) OR
(${USING_TSAN} AND ${USING_ASAN_INT}))
message (WARNING "Cannot use TSAN/ASAN together, defaulting to ASAN")
endif()

if (${USING_ASAN} OR ${USING_ASAN_INT})
if (${USING_ASAN_INT})
add_compile_options(-fsanitize=address,undefined,integer)
else ()
add_compile_options(-fsanitize=address,undefined)
endif()
add_definitions(-DED25519_NO_INLINE_ASM)
elseif (NANO_TSAN OR RAIBLOCKS_TSAN)
elseif (${USING_TSAN})
add_compile_options(-fsanitize=thread)
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options("-fsanitize-blacklist=${PROJECT_SOURCE_DIR}/tsan_blacklist")
Expand Down Expand Up @@ -104,11 +120,11 @@ else ()
set (PLATFORM_LINK_FLAGS "-static-libgcc -static-libstdc++")
endif ()

if (NANO_ASAN OR RAIBLOCKS_ASAN)
set (PLATFORM_LINK_FLAGS "${PLATFORM_LINK_FLAGS} -fsanitize=address,undefined")
elseif (NANO_ASAN_INT OR RAIBLOCKS_ASAN_INT)
if (${USING_ASAN_INT})
set (PLATFORM_LINK_FLAGS "${PLATFORM_LINK_FLAGS} -fsanitize=address,undefined,integer")
elseif (NANO_TSAN OR RAIBLOCKS_TSAN)
elseif (${USING_ASAN})
set (PLATFORM_LINK_FLAGS "${PLATFORM_LINK_FLAGS} -fsanitize=address,undefined")
elseif (${USING_TSAN})
set (PLATFORM_LINK_FLAGS "${PLATFORM_LINK_FLAGS} -fsanitize=thread")
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
set (PLATFORM_LINK_FLAGS "${PLATFORM_LINK_FLAGS} -fsanitize-blacklist=${PROJECT_SOURCE_DIR}/tsan_blacklist")
Expand Down