Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "seed" option to CLI #1772

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Add "seed" option to CLI #1772

merged 2 commits into from
Feb 24, 2019

Conversation

SergiySW
Copy link
Contributor

Supported in wallet_change_seed & wallet_create
Following #793

Supported in wallet_change_seed & wallet_create
@SergiySW SergiySW added the tool Introduces or updates a tool or command label Feb 24, 2019
@SergiySW SergiySW added this to the V19.0 milestone Feb 24, 2019
@SergiySW SergiySW self-assigned this Feb 24, 2019
@SergiySW SergiySW merged commit 3da9b48 into nanocurrency:master Feb 24, 2019
@zhyatt zhyatt added the documentation This item indicates the need for or supplies updated or expanded documentation label Feb 26, 2019
@zhyatt
Copy link
Collaborator

zhyatt commented Jul 5, 2019

@SergiySW Was the optional "seed" available for wallet_create in V18 before? Or is it new for V19? See docs here indicating it was in V18: https://docs.nano.org/commands/rpc-protocol/#wallet_create . Also does response when seed is included in wallet_create return "last restored account from given seed & restored count" as it indicates?

@zhyatt
Copy link
Collaborator

zhyatt commented Jul 11, 2019

I was getting RPC and CLI crossed up. Updating documentation to reflect change to seed option from key.

@zhyatt zhyatt removed the documentation This item indicates the need for or supplies updated or expanded documentation label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Introduces or updates a tool or command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants