Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nested if/else with map for no argument rpc_handler functions #1796

Merged
merged 2 commits into from
Mar 2, 2019
Merged

Replace nested if/else with map for no argument rpc_handler functions #1796

merged 2 commits into from
Mar 2, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Mar 1, 2019 •
edited
Loading

MSVC has a limit of 128 nested blocks.
Also moved rpc_handler constructor definition to be with the other rpc_handler functions

@wezrule wezrule added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Mar 1, 2019
@wezrule wezrule added this to the V19.0 milestone Mar 1, 2019
@wezrule wezrule self-assigned this Mar 1, 2019
cryptocode
cryptocode approved these changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wezrule wezrule merged commit b2f9ee3 into nanocurrency:master Mar 2, 2019
@wezrule wezrule deleted the map_for_rpc branch March 2, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

Assignees

@wezrule wezrule

Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wezrule @cryptocode