Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent (optionally) block processor batched writes from being logged by the lmdb tracker #1978

Conversation

@wezrule
Copy link
Collaborator

commented May 11, 2019

Most write log entries from the lmdb tracker are for the Blck processing thread. This is expected when bootstrapping as we process writes in batches according to the block_processor_batch_max_time. This can become quite noisy (~80000 lines are safe to ignore in a full bootstrap on my Windows/debug test). This is added to the diagnostics -> txn_tracker config so that it can be toggled (default is to ignore them).

I get a lot of writes held longer than the "max", for instance using the default 5000ms block_processor_batch_max_time there are a few like so:

[2019-05-11 16:33:54.757606]: 7547ms write lock held on thread Blck processing

So I have added a few seconds buffer onto it when checking whether it should be output to trim these away as well.

@wezrule wezrule added this to the V19.0 milestone May 11, 2019

@wezrule wezrule requested a review from SergiySW May 11, 2019

@wezrule wezrule self-assigned this May 11, 2019

@wezrule wezrule added this to During RC in V19 May 11, 2019

@zhyatt zhyatt requested a review from cryptocode May 14, 2019

@wezrule wezrule merged commit 3a0173f into nanocurrency:master May 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:ignore_blk_processor_batched_writes_lmdb_tracker branch May 14, 2019

@wezrule wezrule moved this from During RC to RC 3 (TBD) in V19 May 14, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.