Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling to RPC process without json_block #2377

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add error handling to RPC process without json_block #2377

merged 1 commit into from
Oct 31, 2019

Conversation

guilhermelawless
Copy link
Contributor

@guilhermelawless guilhermelawless commented Oct 31, 2019 •
edited
Loading

boost::property_tree::read_json (block_stream, block_l); needed a try/catch as we have in other places. Added some test cases.

Thanks @Joohansson for the report

@guilhermelawless guilhermelawless added this to the V20.0 milestone Oct 31, 2019
@guilhermelawless guilhermelawless self-assigned this Oct 31, 2019
@guilhermelawless guilhermelawless merged commit 4069341 into nanocurrency:master Oct 31, 2019
@guilhermelawless guilhermelawless deleted the rpc/process-try-catch branch October 31, 2019 22:15
argakiig pushed a commit that referenced this pull request Nov 1, 2019
@guilhermelawless
Add error handling to RPC process without json_block (#2377)
5897cfb
@zhyatt zhyatt added rpc Changes related to Remote Procedure Calls and removed rpc nonbreaking change labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argakiig argakiig argakiig approved these changes

Assignees

@guilhermelawless guilhermelawless

Labels
bug rpc Changes related to Remote Procedure Calls
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelawless @argakiig @zhyatt