Add logging section to rpc config to optionally disable logging #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Tested loggging on/off as node process, child process and out of process, working as expected.
@zhyatt do we want to note this one in the release notes?
16 tasks
|
@guilhermelawless That seems reasonable. Added to items in nanocurrency/nano-docs#271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JSON's ramdisk node is crashing when pumping out 2000BPS
processRPC calls. There are some boost standard error outputs suggesting problems with rotating the files at this high logging output speed.However I cannot reproduce this even, even with spamming 50MB of log messages per second over a few threads. Seems to be something special about his set-up, removing the logging output manually fixed the issue for him, so am adding a logging section to the rpc config which allows these messages to be disabled (they are enabled by default). This can be extended in the future to change the rotation/max size size and maybe some other options, but right now this should be sufficient.