Remove conf height put during ledger processing on a newly opened account #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
force-pushed
the
conf_height_move_from_ledger
branch
from
5704c2e
to
f630d40
Compare
wezrule
force-pushed
the
conf_height_move_from_ledger
branch
from
35bb721
to
b94dd94
Compare
SergiySW
reviewed
Oct 15, 2020
SergiySW
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account is opened the confirmation height database adds the account with height/frontier of 0. This is unnecessary as the lack of this existing means these values are implicitly 0. This PR makes that change.
This allows us to set
allow_concurrent_memtable_writesto false in RocksDB and enables use of theHashSkipListFactoryfor memtables enabling faster point reads. This does mean that we can no longer write multiple independent things in RocksDB, but we don't currently do that with anything else.In the future this could enable a separate LMDB database store to be used to get better block processing/conf height performance with LMDB because they currently block each other on writes and could also remove the write database queue (although it's useful for teats still). This is not done here.
Added a test for #2777
unconfirmed frontiersClearing confirmation height now just removes the whole table rather than reset every account individually.