[RocksDB] Reduce number of blocks processed in batch by block processor #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a write transaction commit error during block processing with RocksDB:
That option is deprecated and don't really want to increase the number of memtables either (currently at 2). Reducing the amount of blocks processed seems to resolve this, we currently do 5s by default, and even more with
--fast_bootstrap.Tested a full bootstrap on beta with
--fast_bootstrap, took 40 minutes to get all 3.5M checked blocks, and live took me 7 hours.Bugs: Fix incorrect
debug_assertcomparison and some failing tests on RocksDB