Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty uint8_t peer data #2944

Merged
merged 6 commits into from
Sep 21, 2020
Merged

Use empty uint8_t peer data #2944

merged 6 commits into from
Sep 21, 2020

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Sep 16, 2020 •
edited
Loading

to save disk space

ASAN/TSAN/Valgrind tests with different compilers are welsome

@SergiySW SergiySW added the database structure If the database changes it needs updating in the nanodb repository label Sep 16, 2020
@SergiySW SergiySW added this to the V22.0 milestone Sep 16, 2020
@SergiySW SergiySW self-assigned this Sep 16, 2020
@SergiySW SergiySW changed the title Use empty peer data Use empty uint8_t peer data Sep 16, 2020
wezrule
wezrule previously approved these changes Sep 18, 2020
View reviewed changes
@cryptocode
Copy link
Contributor

cryptocode commented Sep 18, 2020 •
edited
Loading

Would a key-only put overload make sense so the caller doesn't need to know the no-data representation? Could be used for the future pruned_put as well I think.

@SergiySW
Copy link
Contributor Author

@cryptocode sure, make sense

@SergiySW SergiySW dismissed stale reviews from ghost and wezrule via bdae56c September 18, 2020 19:12
@SergiySW SergiySW merged commit bd01435 into nanocurrency:develop Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@guilhermelawless guilhermelawless Awaiting requested review from guilhermelawless

Assignees

@SergiySW SergiySW

Labels
database structure If the database changes it needs updating in the nanodb repository
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @cryptocode @wezrule @clemahieu