-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add include_only_confirmed to account_balance & account_info #3022
Merged
wezrule
merged 6 commits into
nanocurrency:develop
from
wezrule:only_confirmed_account_balance_info
Oct 30, 2020
Merged
Add include_only_confirmed to account_balance & account_info #3022
wezrule
merged 6 commits into
nanocurrency:develop
from
wezrule:only_confirmed_account_balance_info
Oct 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
reviewed
Oct 26, 2020
1 task
SergiySW
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cryptocode
approved these changes
Oct 30, 2020
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
This item indicates the need for or supplies updated or expanded documentation
rpc
Changes related to Remote Procedure Calls
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
include_only_confirmed
to account_balance and account_info RPC calls forbalance
&pending
.account_balance
is useful as it can give pending amounts for not-yet opened accounts and is quite a good utility.