Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_only_confirmed to account_balance & account_info #3022

Merged

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Oct 26, 2020

This adds include_only_confirmed to account_balance and account_info RPC calls for balance & pending. account_balance is useful as it can give pending amounts for not-yet opened accounts and is quite a good utility.

@wezrule wezrule added the rpc Changes related to Remote Procedure Calls label Oct 26, 2020
@wezrule wezrule added this to the V22.0 milestone Oct 26, 2020
@wezrule wezrule self-assigned this Oct 26, 2020
nano/secure/ledger.cpp Outdated Show resolved Hide resolved
@zhyatt zhyatt added this to Pending testing evaluation in V22.0DB10 via automation Oct 26, 2020
@wezrule wezrule added the documentation This item indicates the need for or supplies updated or expanded documentation label Oct 27, 2020
Copy link
Contributor

@SergiySW SergiySW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wezrule wezrule merged commit cd7891d into nanocurrency:develop Oct 30, 2020
@wezrule wezrule deleted the only_confirmed_account_balance_info branch October 30, 2020 12:43
@zhyatt zhyatt removed this from Pending testing evaluation in V22.0DB10 Oct 30, 2020
@zhyatt zhyatt added this to Pending testing evaluation in V22.0DB9 via automation Oct 30, 2020
@zhyatt zhyatt moved this from Pending testing evaluation to Pending general testing in V22.0DB9 Oct 30, 2020
@zhyatt zhyatt moved this from Pending general testing to Testing completed in V22.0DB9 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Projects
No open projects
V22.0DB9
Testing completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants