Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check open file descriptor limit, warn if low #3107

Merged
merged 5 commits into from
Mar 16, 2021

Conversation

cryptocode
Copy link
Contributor

Sample output (stderr and log)

WARNING: The file descriptor limit on this system may be too low (512) 
and should be increased to at least 16384.

This can be tested with docker run --ulimit nofile=512:1024 ...

@cryptocode cryptocode self-assigned this Mar 1, 2021
@zhyatt zhyatt requested review from wezrule and argakiig March 1, 2021 16:56
@SergiySW
Copy link
Contributor

SergiySW commented Mar 1, 2021

Could rlim_cur be lower than rlim_max ?

@cryptocode
Copy link
Contributor Author

cryptocode commented Mar 1, 2021

@SergiySW yes, but the soft limit (rlim_cur) is what processes run into, rlim_max is the system hard limit, for processes trying to increase the limit programmatically. Do you mean rlim_max should be checked still?

@wezrule wezrule added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Mar 2, 2021
@wezrule wezrule added this to the V22.0 milestone Mar 2, 2021
@SergiySW
Copy link
Contributor

SergiySW commented Mar 2, 2021

@SergiySW yes, but the soft limit (rlim_cur) is what processes run into, rlim_max is the system hard limit, for processes trying to increase the limit programmatically. Do you mean rlim_max should be checked still?

Yes, I wonder if need to check it as well

@SergiySW SergiySW merged commit 1b24800 into nanocurrency:develop Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants