Remove 1 sec socket timeout in dev mode (becomes 2 sec as in normal m… #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode) A 1 second timeout seems a little too aggressive even in dev mode. It can lead to false failures in tests. Also, it is a complication too far. It is an extra logical branch, a complication that, as far as I can see, it does not give us anything useful, except from the possibility of slightly faster unit test runs but reliability should be more important than a possible slight speed increase in unit test execution.
clemahieu
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode)
A 1 second timeout seems a little too aggressive even in dev mode.
It can lead to false failures in tests.
Also, it is a complication too far. It is an extra logical branch,
a complication that, as far as I can see, it does not give us anything
useful, except from the possibility of slightly faster unit test runs but
reliability should be more important than a possible slight speed increase
in unit test execution.