Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in const correctness and 'const' positioning #3510

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Improvements in const correctness and 'const' positioning #3510

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d33d37
Improve const correctness and adhere to 'const' specifier positioning…
Oct 20, 2021
5988e03
Fix formatting
Oct 20, 2021
d97b942
Fix build
Oct 20, 2021
f9fcf85
Add std::move
Oct 20, 2021
560b443
Improve const correctness
marioortizmanero Mar 14, 2021
0870f59
Fix build
Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nano/lib/errors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ nano::error & nano::error::on_error (std::error_code code_a, std::string message
/** Set an error message and an error code */
nano::error & nano::error::set (std::string message_a, std::error_code code_a)
{
message = message_a;
message = std::move (message_a);
code = code_a;
return *this;
}
Expand All @@ -486,6 +486,7 @@ nano::error & nano::error::clear ()
return *this;
}

// TODO: theoretically, nothing besides template (partial) specializations should ever be added inside std...
theohax marked this conversation as resolved.
Show resolved Hide resolved
namespace std
{
std::error_code make_error_code (boost::system::errc::errc_t const & e)
Expand Down