Final vote requests/replies only #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at counters will increment for both requests.
clemahieu
force-pushed
the
final-replies-only
branch
from
be28e2b
to
c725bc4
Compare
# Conflicts: # nano/core_test/request_aggregator.cpp
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main changes:
During testing it was shown that the above changes reduce vote traffic by an order of magnitude.
The rationale for abandoning replies from vote cache is that it causes excessive bandwidth usage. A vote request might contain 12 hashes (255 hashes after upcoming network upgrade) and the chance that a vote with exactly these hashes is already cached is low. This in turn requires replying with multiple votes, which is incredibly inefficient. Pessimistic bandwidth usage in such scenario is number of hashes squared.