Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in derived params when OMDOT uncertainty is 0 #1689

Merged
merged 2 commits into from Dec 11, 2023

Conversation

dlakaplan
Copy link
Contributor

Closes #1688

Tried to compute Mtot from OMDOT including uncertainty in fitter.derived_params(). But in this case OMDOT had no uncertainty since it was a funcParameter. Now has explicit protection against 0 uncertainties (whether from this or a frozen model).

Related question: should the Mtot computation there happen at all if OMDOT < 0?

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c406161) 68.41% compared to head (7896a55) 68.41%.

❗ Current head 7896a55 differs from pull request most recent head 28069fe. Consider uploading reports for the commit 28069fe to get more accurate results

Files Patch % Lines
src/pint/fitter.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1689   +/-   ##
=======================================
  Coverage   68.41%   68.41%           
=======================================
  Files         104      104           
  Lines       24339    24339           
  Branches     4346     4346           
=======================================
  Hits        16651    16651           
  Misses       6600     6600           
  Partials     1088     1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlakaplan dlakaplan added the awaiting review This PR needs someone to review it so it can be merged label Dec 10, 2023
@abhisrkckl abhisrkckl merged commit fc61ed6 into nanograv:master Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fitter.get_derived_params() fails for ELL1/ELL1H models with nonzero EPS1DOT/EPS2DOT
3 participants