-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MQTT5.0 codec. #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that nng_msg_proto_set_property()/nng_msg_proto_get_property() functions can not be called by client application.
8bf42a3
to
2e1472c
Compare
src/mqtt/mqtt_codec.c
Outdated
"id: %d, value: %d (U8)", prop_id, prop->data.p_value.u8); | ||
break; | ||
case U16: | ||
read_uint16(buf, &prop->data.p_value.u16); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check return value
FIX #19 |
59bfdfa
to
ec40ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not done yet
2104a06
to
be380b1
Compare
please test and rework whole PR |
and keep the original field in conn_param feasible. because we use it everywhere. |
9561acf
to
b6403c3
Compare
nni_msg_append(msg, &(cparam->rx_max), 2); | ||
remaining_len += 3; | ||
} | ||
if (cparam->assignedid == true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assignedID does not work now
assign clientid failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alvin1221 fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good
No description provided.