Add MQTT5.0 codec. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvin1221
commented
Feb 23, 2022
alvin1221
force-pushed
the
alvin/mqtt5_codec
branch
from
8bf42a3
to
2e1472c
Compare
xinyi-xs
reviewed
Feb 23, 2022
src/mqtt/mqtt_codec.c
Outdated
| "id: %d, value: %d (U8)", prop_id, prop->data.p_value.u8); | ||
| break; | ||
| case U16: | ||
| read_uint16(buf, &prop->data.p_value.u16); |
There was a problem hiding this comment.
You should check return value
JaylinYu
approved these changes
Feb 24, 2022
|
FIX #19 |
xinyi-xs
reviewed
Mar 1, 2022
alvin1221
force-pushed
the
alvin/mqtt5_codec
branch
3 times, most recently
from
59bfdfa
to
ec40ed4
Compare
alvin1221
force-pushed
the
alvin/mqtt5_codec
branch
from
2104a06
to
be380b1
Compare
|
please test and rework whole PR |
|
and keep the original field in conn_param feasible. because we use it everywhere. |
JaylinYu
force-pushed
the
alvin/mqtt5_codec
branch
from
9561acf
to
b6403c3
Compare
JaylinYu
approved these changes
Mar 9, 2022
| nni_msg_append(msg, &(cparam->rx_max), 2); | ||
| remaining_len += 3; | ||
| } | ||
| if (cparam->assignedid == true) { |
There was a problem hiding this comment.
assignedID does not work now
assign clientid failed
JaylinYu
added a commit
that referenced
this pull request
Mar 11, 2022
This was referenced Feb 13, 2023
This was referenced Mar 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.