Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failed on Windows #510

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix build failed on Windows #510

merged 1 commit into from
Apr 14, 2023

Conversation

alvin1221
Copy link
Contributor

No description provided.

@alvin1221 alvin1221 self-assigned this Apr 14, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (1f3d63e) 51.48% compared to head (5cfd69d) 51.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
- Coverage   51.48%   51.36%   -0.12%     
==========================================
  Files         120      120              
  Lines       36291    36291              
==========================================
- Hits        18683    18642      -41     
- Misses      17608    17649      +41     
Impacted Files Coverage Δ
src/supplemental/nanolib/log.c 0.00% <ø> (ø)

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JaylinYu JaylinYu merged commit 6319293 into main Apr 14, 2023
10 of 14 checks passed
@JaylinYu JaylinYu deleted the alvin/fix_win branch April 14, 2023 10:36
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants