test for broker-tcp and nmq-mqtt #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 51.27% 53.73% +2.45%
==========================================
Files 120 120
Lines 36422 36416 -6
==========================================
+ Hits 18677 19569 +892
+ Misses 17745 16847 -898 see 24 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
StargazerWayne
force-pushed
the
herman/dev
branch
2 times, most recently
from
6444e08
to
f0af841
Compare
wanghaEMQ
requested changes
Apr 18, 2023
tests/trantest.h
Outdated
| } | ||
| if (nng_ctx_open(&work->ctx, tt->repsock) != 0) { | ||
| printf("ctx_open fail\n"); | ||
| } |
There was a problem hiding this comment.
Using assert or something else instead of IF or PRINTF ?
StargazerWayne
force-pushed
the
herman/dev
branch
from
d8f145f
to
b0b6476
Compare
StargazerWayne
force-pushed
the
herman/dev
branch
from
b0b6476
to
ca5538c
Compare
wanghaEMQ
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.