* MDF [mqtt_msg] init objs of proto_Data struct #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 53.04% 52.92% -0.12%
==========================================
Files 120 120
Lines 36715 36728 +13
==========================================
- Hits 19474 19440 -34
- Misses 17241 17288 +47
☔ View full report in Codecov by Sentry. |
xinyi-xs
reviewed
Jun 29, 2023
| @@ -16,6 +16,18 @@ nni_proto_data_init(nni_mqtt_proto_data *proto_data) | |||
| { | |||
| proto_data->var_header.connect.conn_flags.clean_session = true; | |||
| proto_data->var_header.connect.keep_alive = 30; | |||
| proto_data->var_header.connack.properties = NULL; | |||
There was a problem hiding this comment.
It's a union here, the initialize seems improper?
There was a problem hiding this comment.
I guess we don't need this function, all we need is just memset proto_data is zero.
|
TODO: memset proto_data to /0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync fix from nanosdk