Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark tests are busted #69

Closed
gdamore opened this issue Nov 2, 2018 · 0 comments
Closed

Benchmark tests are busted #69

gdamore opened this issue Nov 2, 2018 · 0 comments

Comments

@gdamore
Copy link
Contributor

gdamore commented Nov 2, 2018

The latency tests are busted, as the code is written to assume Dial retries. Now that we have synchronous Dial, we should wait until the listener is started before dialing.
gdamore added a commit that referenced this issue Nov 2, 2018
@gdamore
fixes #69 Accept spinning terribly
6e0bb6b
@gdamore gdamore closed this as completed in bbefd98 Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdamore