Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic in req #264

Closed
gdamore opened this issue Aug 11, 2022 · 0 comments
Closed

panic in req #264

gdamore opened this issue Aug 11, 2022 · 0 comments

Comments

@gdamore
Copy link
Contributor

gdamore commented Aug 11, 2022

At RackTop, we encountered a panic in the req code:

[signal SIGSEGV: segmentation violation code=0x1 addr=0x78 pc=0x96bb85]

goroutine 958498 [running]:
go.nanomsg.org/mangos/v3.(*Message).Clone(...)
go.nanomsg.org/mangos/v3@v3.3.0/message.go:129
go.nanomsg.org/mangos/v3/protocol/req.(*socket).send(0xc000900600)
go.nanomsg.org/mangos/v3@v3.3.0/protocol/req/req.go:90 +0x165
go.nanomsg.org/mangos/v3/protocol/req.(*context).resendMessage(0xc0038483f0, 0x9ba726b0)
go.nanomsg.org/mangos/v3@v3.3.0/protocol/req/req.go:185 +0x13c
go.nanomsg.org/mangos/v3/protocol/req.(*socket).send.func1()
go.nanomsg.org/mangos/v3@v3.3.0/protocol/req/req.go:99 +0x31
created by time.goFunc
time/sleep.go:180 +0x45
[ Jul 22 18:36:48 Stopping because all processes in service exited. ]

What is happening appears to be that for whatever reason by the time we wind up calling s.send(), the message is no longer set on the context, but the context is still in the sendq. Quite possibly this is linked to cancellation.

Anyway if m turns out to be nil, we should just continue the loop and skip the context.

gdamore added a commit that referenced this issue Aug 11, 2022
gdamore added a commit that referenced this issue Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant