nng_opts_parse() uses const incorrectly #715
Milestone
Comments
gdamore
added a commit
to staysail/nng
that referenced
this issue
Sep 12, 2018
The fix for nanomsg#715 to address const is still not quite right. In ISO C, the argv array is just char **. getopt() in POSIX uses char *const[]. That part is right, but we should then not pass const char ** in calls. Furthermore, really the optarg should also not be constified. This aligns us closer to getopt() and leads to the fewest problems. This does represent a slight breaking change, but as old code should still compile and run, we don't think we should bump the API version for this change. Furthermore, we don't think anyone else is actually using this API yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The passing of the argv array as const char ** is wrong, and means you can't pass the normal arguments that you would from main(int argc, char **argv) without breaking things.
What is desired instead is char *const *.
This is the correct passing for C99.
The text was updated successfully, but these errors were encountered: