Skip to content

Commit

Permalink
Merge branch 'jdaw/add-fast5-depracation-warning' into 'master'
Browse files Browse the repository at this point in the history
Add deprecation warning for FAST5

Closes DOR-534

See merge request machine-learning/dorado!846
  • Loading branch information
tijyojwad committed Mar 8, 2024
2 parents bdc05e3 + 97ca8d2 commit 13ba5af
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion dorado/data_loader/DataLoader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ std::vector<std::filesystem::directory_entry> filter_fast5_for_mixed_datasets(
if (ext == ".fast5") {
if (!issued_fast5_warn) {
spdlog::warn(
"FAST5 support is unoptimized and will result in poor performance. "
"Deprecation Warning: FAST5 support in Dorado will be dropped in an "
"upcoming "
"release. "
"FAST5 loading is unoptimized and will result in poor performance. "
"Please convert your dataset to POD5: "
"https://pod5-file-format.readthedocs.io/en/latest/docs/"
"tools.html#pod5-convert-fast5");
Expand Down

0 comments on commit 13ba5af

Please sign in to comment.