Adjust min_flank_score threshold to 0.5

and fix failing integration test.
nanoporetech · Mar 21, 2024 · 351f333 · 351f333
1 parent dad9593
commit 351f333
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dorado/utils/barcode_kits.h b/dorado/utils/barcode_kits.h
@@ -16,7 +16,7 @@ struct BarcodeKitScoringParams {
     int flank_right_pad = 10;
     int front_barcode_window = 175;
     int rear_barcode_window = 175;
-    float min_flank_score = 0.6f;
+    float min_flank_score = 0.5f;
 };
 
 struct KitInfo {

diff --git a/tests/test_simple_basecaller_execution.sh b/tests/test_simple_basecaller_execution.sh
@@ -335,8 +335,8 @@ test_barcoding_read_groups() (
 
 # There should be 4 reads with BC01, 3 with BC04, and 2 unclassified groups.
 test_barcoding_read_groups barcode01 4 barcode04 3 unclassified 2
-# There should be 5 reads with BC01 aliased to patient_id_1, and 4 unclassified groups.
-test_barcoding_read_groups patient_id_1 5 unclassified 4 $data_dir/barcode_demux/sample_sheet.csv
+# There should be 4 reads with BC01 aliased to patient_id_1, and 5 unclassified groups.
+test_barcoding_read_groups patient_id_1 4 unclassified 5 $data_dir/barcode_demux/sample_sheet.csv
 
 # Test demux only on a pre-classified BAM file
 $dorado_bin demux --no-classify --output-dir "$output_dir/demux_only_test/" $output_dir/read_group_test.bam