Merge branch 'smalton/DOR-463-bionic-cpu-warning' into 'master'

DOR-463: Bionic cpu warning Closes DOR-463 See merge request machine-learning/dorado!756
nanoporetech · Dec 7, 2023 · 936d408 · 936d408
2 parents 0d932c0 + 525e297
commit 936d408
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/dorado/nn/ModelRunner.h b/dorado/nn/ModelRunner.h
@@ -5,8 +5,6 @@
 #include "decode/Decoder.h"
 #include "utils/stats.h"
 
-#include <spdlog/spdlog.h>
-#include <toml.hpp>
 #include <torch/nn.h>
 
 #include <atomic>

diff --git a/dorado/nn/Runners.cpp b/dorado/nn/Runners.cpp
@@ -15,6 +15,7 @@
 #endif  // DORADO_GPU_BUILD
 
 #include <cxxpool.h>
+#include <spdlog/spdlog.h>
 
 #include <thread>
 
@@ -39,6 +40,10 @@ std::pair<std::vector<dorado::Runner>, size_t> create_basecall_runners(
     size_t num_devices = 1;
 
     if (device == "cpu") {
+#ifdef DORADO_TX2
+        spdlog::warn("CPU basecalling is not supported on this platform. Results may be incorrect");
+#endif  // #ifdef DORADO_TX2
+
         if (batch_size == 0) {
             batch_size = 128;
         }