Skip to content

Commit

Permalink
Merge branch 'rh/DOR-517_allow_missing_standardisation_params' into '…
Browse files Browse the repository at this point in the history
…master'

DOR-517 only require standardisation params if active

Closes DOR-517

See merge request machine-learning/dorado!795

(cherry picked from commit 3c1cd85)

deeca249 only require standardisation params if active
  • Loading branch information
HalfPhoton authored and tijyojwad committed Jan 17, 2024
1 parent d5935a9 commit 9959654
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions dorado/basecall/CRFModelConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,10 @@ SignalNormalisationParams parse_signal_normalisation_params(const toml::value &c
if (config_toml.contains("standardisation")) {
const auto &norm = toml::find(config_toml, "standardisation");
params.standarisation.standardise = toml::find<int>(norm, "standardise") > 0;
params.standarisation.mean = toml::find<float>(norm, "mean");
params.standarisation.stdev = toml::find<float>(norm, "stdev");
if (params.standarisation.standardise) {
params.standarisation.mean = toml::find<float>(norm, "mean");
params.standarisation.stdev = toml::find<float>(norm, "stdev");
}

if (params.standarisation.standardise && params.strategy != ScalingStrategy::PA) {
throw std::runtime_error(
Expand Down

0 comments on commit 9959654

Please sign in to comment.