Skip to content

Commit

Permalink
BAM output for dorado trim
Browse files Browse the repository at this point in the history
Previous default was being set to SAM due to
a bug in the cli code. This is now changed to output
BAM or UBAM.
  • Loading branch information
tijyojwad committed Apr 24, 2024
1 parent 9e5c55b commit abaa532
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions dorado/cli/trim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,11 @@ int trim(int argc, char* argv[]) {
auto output_mode = OutputMode::BAM;

auto emit_fastq = parser.get<bool>("--emit-fastq");
auto emit_sam = !emit_fastq;

if (emit_fastq) {
spdlog::info(" - Note: FASTQ output is not recommended as not all data can be preserved.");
output_mode = OutputMode::FASTQ;
} else if (emit_sam || utils::is_fd_tty(stdout)) {
} else if (utils::is_fd_tty(stdout)) {
output_mode = OutputMode::SAM;
} else if (utils::is_fd_pipe(stdout)) {
output_mode = OutputMode::UBAM;
Expand Down

0 comments on commit abaa532

Please sign in to comment.