Split error message to wrap suggestions without duplication

nanoporetech · Dec 5, 2023 · e5b95cc · e5b95cc
1 parent 66ba4ba
commit e5b95cc
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/dorado/models/models.cpp b/dorado/models/models.cpp
@@ -159,13 +159,11 @@ ModelInfo find_model(const std::vector<ModelInfo>& models,
     const auto matches = find_models(models, chemistry, model, mods);
 
     if (matches.empty()) {
+        spdlog::error("Failed to get {} model", description);
         if (suggestions) {
-            spdlog::error("Failed to get {} model. No matches for {}", description,
-                          format_msg(chemistry, model, mods));
             suggest_models(models, description, chemistry, model, mods);
         }
-        throw std::runtime_error("Failed to get " + description + " model. No matches for " +
-                                 format_msg(chemistry, model, mods));
+        throw std::runtime_error("No matches for " + format_msg(chemistry, model, mods));
     }
 
     // Get the only match or the latest model