Skip to content

Commit

Permalink
Disable keepalive
Browse files Browse the repository at this point in the history 
This is causing an error (#23) because we aren't actually checking out the repo.

Need to revisit at a later stage.
  • Loading branch information
@nanos
nanos committed Mar 22, 2023
1 parent afc9819 commit 0d95631
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/get_context.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ jobs:
name: artifacts
path: |
artifacts
- name: Keep workflow alive
uses: gautamkrishnar/keepalive-workflow@v1
# - name: Keep workflow alive
# uses: gautamkrishnar/keepalive-workflow@v1

4 comments on commit 0d95631

@elias-fox
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to fix the error on my copy by adding actions/checkout: https://github.com/elias-fox/mastodon_get_replies/commit/e35e4535e53f5e4dd5385fe81fa06875061c6615

@nanos
Copy link
Owner Author

@nanos nanos commented on 0d95631 Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elias-fox. That’s what I’ll probably end up doing.
i keep thinking there must be a better way of doing that though: it just seems dirty to checkout the whole repo, just to check whether a commit is needed.

@elias-fox
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it seems like the original author expects you to do just that, but maybe it feels less egregious in their imagined use.

@nanos
Copy link
Owner Author

@nanos nanos commented on 0d95631 Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I mean, ultimately you must check it out, to add a commit. But when running every 10 min, and making a commit after 50 days that’s 72k unnecessary checkouts, and just feels inelegant.

Either way, it’s what I’ll probably end up doing.

Please sign in to comment.