Store atom state in context #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check referential equality before notifying React useSyncExternalStore triggers rerenders only when value is not referentially equal to previous one. Here updated atom to not notify subscriptions when new value is same. This change will let as avoid additional checks in user land and rely more on store.subscribe in non-react logic. * Remove packageManager
* Avoid copying listeners Found the source of change here nanostores@242d2b1 Though back then listeners were called in the same loop. Now listeners are called when iterating over listenerQueue which makes copying unnecessary. * Latest node is putting byte here for some reason
`store.notify()` was used to enforce update when no value is changed though this case is not valid in react which checks referential equality before update. Here remove store.notify from types andd dropped notifyId which was used to enforce recomputing of dependent computed stores.
Ref nanostores#171 Here's initial attempt to move all stores state into global context object. Context is basically a listeners queue and a map of stores states. Context management api is still yet to explore. For now it's for internal usage now.
|
Thanks. I plan to review it when I will come back from China, on next week. |
|
At first glance it looks solid for me. But I am afraid to release it in 0.9 and will release your previous PRs first. |
|
Sure, sounds fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #171
Here's initial attempt to move all stores state into global context object. Context is basically a listeners queue and a map of stores states.
Context management api is still yet to explore. For now it's for internal usage now.
The important thing here is accessing context with getter function which can allow to use AsyncLocalStorage in node and cloudflare workers.