feat!: does not run queued listeners after they are unsubscribed #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gismya
force-pushed
the
remove-listener-from-queue
branch
from
59ff8f4
to
0377ef5
Compare
|
Thanks |
ai
pushed a commit
that referenced
this pull request
Apr 1, 2024
ai
pushed a commit
that referenced
this pull request
Apr 1, 2024
ai
pushed a commit
that referenced
this pull request
Apr 24, 2024
ai
pushed a commit
that referenced
this pull request
Apr 24, 2024
ai
pushed a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behaviour of unsubscribe to also remove listeners that have already been queued.
It's a breaking change.
I remade the tests "does not mutate listeners while change event". Can't really work out what it was testing, and if/how I should replace it with something else.