New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🔄 PropertyKey => KeyofBase #88

Merged

ai merged 1 commit into nanostores:main from Beraliv:fix/property-key

Dec 20, 2021

Contributor

Beraliv commented Dec 20, 2021 •

edited

The bug that we found in ts-essentials – ts-essentials breaks with keyofStringsOnly typescript compiler option ts-essentials/ts-essentials#278 (comment)
The explanation in the release – https://devblogs.microsoft.com/typescript/announcing-typescript-2-9-2/#support-for-symbols-and-numeric-literals-in-keyof-and-mapped-object-types
The change is connected with fix: union type in createMap #53

That's the way how to tolerate keyofStringsOnly option in TypeScript


          fix: ➕ add KeyofBase

dfc3d69

ai merged commit da48716 into nanostores:main

Member

ai commented Dec 20, 2021

Do we need to release it or the problem is theoretical?

Contributor Author

Beraliv commented Dec 20, 2021 •

edited

The problem is only in the projects that use keyofStringsOnly

If you didn't see reports yet, it means that no one used it yet

Beraliv deleted the fix/property-key branch

December 20, 2021 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment