-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments from the Bioconductor reviewer #5
Comments
I remove zzz.R after discussing it with Dave and Rona. |
@dnadave for the top item, they just want us to double check that we have everything we need exported right? There's no edit to the code if we feel all is as it should be. |
I don't think we need to export any other functions than what we have in
the NAMESPACE file now. I think we're good.
…On Tue, Jan 5, 2021 at 3:50 PM Nicole Ortogero ***@***.***> wrote:
@dnadave <https://github.com/dnadave> for the top item, they just want us
to double check that we have everything we need exported right? There's no
edit to the code if we feel all is as it should be.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJVFGZKDJCMAECQEJ4R52LSYOQVRANCNFSM4VMKX6UA>
.
--
David Henderson, Ph.D.
18476 47th Place NE
Lake Forest Park, WA 98155
206-794-8552
|
Left one sapply in esBy as this is sort of an extension of the sapply function for our class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NanoStringNCTools review (Bioconductor/Contributions#1815 (comment))
NAMESPACE
Build report warnings
NOTE: These are the NOTES i'm particular about, please address these. The rest of them are also solvable for the most part (at least the ones you see on the linux builder)
NOTE: Avoid sapply(); use vapply()
NOTE: Consider adding runnable examples to the following man
pages which document exported objects:
geom_beeswarm_interactive.Rd, SignatureSet.Rd
NOTE: Consider adding a NEWS file, so your package news will be
included in Bioconductor release announcements.
The windows build machine issue can be addressed by @hpages better.
R
check http://bioconductor.org/developers/how-to/coding-style/ .
Remove commented out lines of code.
I'm not sure why your zzz.R has the 'testPackage' function called inside of it. This usually isn't the way zzz.R is used.
The text was updated successfully, but these errors were encountered: