Fix Port Conflict Error #1033
Merged
Fix Port Conflict Error #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To find out whether they are being used by other applications.
For linux and osx
Also check message option flags and assign them to config
fabioDMFerreira
suggested changes
May 14, 2021
cmd/cmd_root.go
Outdated
| @@ -31,6 +31,27 @@ func GetRootCommand() *cobra.Command { | |||
| } | |||
| } | |||
|
|
|||
| showErrors, err := cmd.Flags().GetBool("show-errors") | |||
There was a problem hiding this comment.
isn't this being handled by globalFlags.MergeToConfig(config)?
There was a problem hiding this comment.
@fabioDMFerreira oh you right ... I will move that line outside the if block
cmd/cmd_pkg.go
Outdated
| @@ -246,3 +245,14 @@ func loadCommandHandler(cmd *cobra.Command, args []string) { | |||
| exitWithError(err.Error()) | |||
| } | |||
| } | |||
|
|
|||
| func excludeWhitespaces(arr []string) []string { | |||
There was a problem hiding this comment.
does it make sense to move to another file?
There was a problem hiding this comment.
@fabioDMFerreira how about moved to separated util package ?
fabioDMFerreira
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed port conflict error message to be human-readable