Mailtaskupdate - Minor adjustments and unit tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss, the old unit tests were removed as they were all marked as broken since the NAnt 0.90 release (if not, before).
…le mistakes rather than simply passing them on. All new 40+ unit tests for MailTask now pass on both .NET 2.0/4.0.
…s when running on Mono.
|
I'm fine with this. |
dguder
added a commit
that referenced
this pull request
Jan 19, 2012
Mailtaskupdate - Minor adjustments and unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I added about ~40 unit tests just for the redesigned MailTask using the .NET Fake Smtp Server lib, netDumbster. I tried to add all the relevant tests I could think, such as validating different variations of address formats, checking for invalid email addresses, sending to multiple addresses (in the To, CC, BCC, and all three), etc. I also corrected some minor issues that popped up with MailTask while creating the new unit tests. Please let me know if you have questions/comments.
Tested on the following setups:
Thanks,
Ryan