Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link_prefix parameter #108

Merged
merged 7 commits into from
Oct 1, 2017
Merged

Add link_prefix parameter #108

merged 7 commits into from
Oct 1, 2017

Conversation

naokazuterada
Copy link
Owner

@naokazuterada naokazuterada commented Sep 30, 2017

Hi @jonasbn, I added new parameter link_prefix. Please review it.

Changes


BTW, I'm also working on these issues. These contain some breaking changes. So I'm planning to release those as version 3. I will need your help a lot on it too.

Thank you for your help! 👋

@codecov
Copy link

codecov bot commented Sep 30, 2017

Codecov Report

Merging #108 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   93.25%   93.31%   +0.06%     
==========================================
  Files           1        1              
  Lines         326      329       +3     
==========================================
+ Hits          304      307       +3     
  Misses         22       22
Impacted Files Coverage Δ
MarkdownTOC.py 93.31% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ec4d8...285c7ba. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 30, 2017

Coverage Status

Coverage increased (+0.06%) to 93.313% when pulling 285c7ba on link-prefix into 09ec4d8 on master.

@jonasbn
Copy link
Collaborator

jonasbn commented Oct 1, 2017

Sounds good with a new major release, I am ready to be of assistance

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@naokazuterada naokazuterada merged commit 285c7ba into master Oct 1, 2017
@naokazuterada naokazuterada deleted the link-prefix branch October 1, 2017 08:11
@naokazuterada
Copy link
Owner Author

@jonasbn Thank you for reviewing.

@naokazuterada naokazuterada changed the title Add link_prefix parameter Add link_prefix parameter #54 Oct 1, 2017
@naokazuterada naokazuterada changed the title Add link_prefix parameter #54 Add link_prefix parameter Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants