Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split msg generation from driver nodes for Humble #33

Closed
wants to merge 2 commits into from
Closed

Split msg generation from driver nodes for Humble #33

wants to merge 2 commits into from

Conversation

adityakamath
Copy link
Contributor

I got errors when trying to build with ROS 2 Humble, and realized that calling rosidl_generate_interfaces and ament_python_install_package in the same package does not work.

So, I split up the message generation into a separate package.

References:
ros2/rosidl_python#141
https://docs.ros.org/en/humble/How-To-Guides/Ament-CMake-Python-Documentation.html

Functionality is as expected, but I have not tested the docker scripts (since I do not have experience there). @naoki-mizuno could you please review the docker part? Are any changes needed in the .bash script? Is the docker directory in the correct place, or should it be in the root directory?

I would prefer to have these changes in a new humble-devel branch, but it should work perfectly well on foxy.

@naoki-mizuno
Copy link
Owner

I haven't been able to keep up with the latest ROS2 releases, so I really appreciate your help! I'll take a look at it later today, thanks!

@naoki-mizuno
Copy link
Owner

Thanks for your PR! I was able to test the demo script on a docker environment. I did move the docker directory to the root (plus the .gitignore file was outdated for quite a while so fixed that), and went ahead and created a new humble-devel branch, which now is the default branch. Thanks again for your contribution!

@adityakamath
Copy link
Contributor Author

Oh awesome, that was quick! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants