Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Fix #160 #161

Merged
merged 3 commits into from
Apr 30, 2017
Merged

Fix #160 #161

merged 3 commits into from
Apr 30, 2017

Conversation

bewing
Copy link
Member

@bewing bewing commented Apr 27, 2017

Update ping() for EOS to:
Strip trailing ':' from IP address
Check for truncated ECHO_RESPONSE and zero out RTT for that packet
Update normal test
Add truncated test

@bewing
Copy link
Member Author

bewing commented Apr 27, 2017

In [5]: d.ping("8.8.8.8")
Out[5]:
{u'success': {u'packet_loss': 0,
  u'probes_sent': 5,
  u'results': [{u'ip_address': u'8.8.8.8', u'rtt': 0.0},
   {u'ip_address': u'8.8.8.8', u'rtt': 0.0},
   {u'ip_address': u'8.8.8.8', u'rtt': 0.0},
   {u'ip_address': u'8.8.8.8', u'rtt': 0.0},
   {u'ip_address': u'8.8.8.8', u'rtt': 0.0}],
  u'rtt_avg': 24.72,
  u'rtt_max': 24.771,
  u'rtt_min': 24.667,
  u'rtt_stddev': 0.105}}

@coveralls
Copy link

coveralls commented Apr 27, 2017

Coverage Status

Coverage increased (+0.05%) to 80.437% when pulling 77078be on bewing:iss160 into 67db8a0 on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 80.437% when pulling 77078be on bewing:iss160 into 67db8a0 on napalm-automation:develop.

@mirceaulinic mirceaulinic self-requested a review April 27, 2017 14:07
@mirceaulinic mirceaulinic modified the milestones: APPROVED, 0.5.7 Apr 27, 2017
Add tests for DNS hostnames and a case for truncated output with
DNS hostnames
@bewing
Copy link
Member Author

bewing commented Apr 27, 2017

Writing another commit to address #162 as it only affects truncated packets, so don't merge yet

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 80.653% when pulling bd90dfc on bewing:iss160 into 67db8a0 on napalm-automation:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 80.653% when pulling bd90dfc on bewing:iss160 into 67db8a0 on napalm-automation:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 80.653% when pulling bd90dfc on bewing:iss160 into 67db8a0 on napalm-automation:develop.

@dbarrosop
Copy link
Member

+1000 great use of the test cases :)

@dbarrosop dbarrosop merged commit 8b85ba2 into napalm-automation:develop Apr 30, 2017
@bewing bewing deleted the iss160 branch June 6, 2017 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants