This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [5]: d.ping("8.8.8.8")
Out[5]:
{u'success': {u'packet_loss': 0,
u'probes_sent': 5,
u'results': [{u'ip_address': u'8.8.8.8', u'rtt': 0.0},
{u'ip_address': u'8.8.8.8', u'rtt': 0.0},
{u'ip_address': u'8.8.8.8', u'rtt': 0.0},
{u'ip_address': u'8.8.8.8', u'rtt': 0.0},
{u'ip_address': u'8.8.8.8', u'rtt': 0.0}],
u'rtt_avg': 24.72,
u'rtt_max': 24.771,
u'rtt_min': 24.667,
u'rtt_stddev': 0.105}} |
1 similar comment
mirceaulinic
approved these changes
Apr 27, 2017
Add tests for DNS hostnames and a case for truncated output with DNS hostnames
Writing another commit to address #162 as it only affects truncated packets, so don't merge yet |
2 similar comments
+1000 great use of the test cases :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ping() for EOS to:
Strip trailing ':' from IP address
Check for truncated ECHO_RESPONSE and zero out RTT for that packet
Update normal test
Add truncated test