-
Notifications
You must be signed in to change notification settings - Fork 42
Enhance the cli method to allow piping #188
Conversation
1 similar comment
Aren't we overdoing it? Seems like a lot of code for something that you are not even supposed to be using in the first place as this break the whole assumption that napalm is vendor agnostic. |
The |
My easy assumption is that we can't put all the shows into functions in napalm, so we leave a 'back door' thus people can manipulate with, although it's not elegant.
…Sent from my iPhone
On 18 Jul 2017, at 3:57 PM, David Barroso ***@***.***> wrote:
Aren't we overdoing it? Seems like a lot of code for something that you are not even supposed to be using in the first place as this break the whole assumption that napalm is vendor agnostic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Yes, I am fine with the cli command. I just want to make sure we don't overdo it. We are adding +100 lines of code to a method that is "nice to have" only to workaround something the vendor decided not to implement. If this is such an important feature, why is people asking us instead of asking them?
For example? I'd expect a bunch of issues requesting features backing that up ;) |
I have approved the PR as I mostly wanted to give some food for thought. Feel free to merge if you decide so after fixing the small CI issue. |
0764797
to
0903e6b
Compare
0903e6b
to
a8330e8
Compare
One of the most common problems when using the
cli
method in napalm-junos is that Junos does not process the pipes.If we are anyway at enhancing the cli (#186) and align it to the behaviour with the other drivers (which can do piping), this PR addresses to process the piping inside napalm-junos.
Ping @sincerywaing this might interest you as well.
Thoughts?