Return more specific with get_route_to()
#735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mirceaulinic
approved these changes
May 23, 2018
|
+1 |
|
I can't remember why this didn't get merged -- pretty stale at this point. Want me to refresh and review? |
|
@bewing Sounds good to me. |
|
Hey @bewing - suppose it'd be too much to ask you to revisit this and resolve the conflicts? 😅 |
When retrieving a large number of BGP routes, grab all the routes for a specific VRF in a single go, instead of collecting each individual route's BGP details. Newer versions of EOS (Confirmed on 4.20.7M) do not allow simultaneous use of the longer-prefixes and detail modifers for "show ip bgp", so detect this and fall back, resulting in lost peer addresses for the routes. Since this only occurs when `longer` is True, it should be OK until the vendor addresses the behavior change from 4.19 to 4.20
bewing
force-pushed
the
get_route_to_longer
branch
from
e3a424c
to
7c0d416
Compare
|
Rebased and resolved. |
|
Yay, just merged in our oldest PR. Thanks @bewing 🙏 |
neelimapp
pushed a commit
to neelimapp/napalm
that referenced
this pull request
Mar 20, 2020
* Add new kwarg `longer` to `get_route_to` * Add method to test get_route_to with longer kwarg * Update mock driver argument tests * EOS implement get_route_to with longer kwarg * Raise NotImplemented for other driver longer routes * Update sphinx config for method alias * Update mocked data path * Cache BGP entries in get_route_to(longer=True) When retrieving a large number of BGP routes, grab all the routes for a specific VRF in a single go, instead of collecting each individual route's BGP details. Newer versions of EOS (Confirmed on 4.20.7M) do not allow simultaneous use of the longer-prefixes and detail modifers for "show ip bgp", so detect this and fall back, resulting in lost peer addresses for the routes. Since this only occurs when `longer` is True, it should be OK until the vendor addresses the behavior change from 4.19 to 4.20
bharath-ravindranath
pushed a commit
to bharath-ravindranath/napalm
that referenced
this pull request
Apr 19, 2020
* Add new kwarg `longer` to `get_route_to` * Add method to test get_route_to with longer kwarg * Update mock driver argument tests * EOS implement get_route_to with longer kwarg * Raise NotImplemented for other driver longer routes * Update sphinx config for method alias * Update mocked data path * Cache BGP entries in get_route_to(longer=True) When retrieving a large number of BGP routes, grab all the routes for a specific VRF in a single go, instead of collecting each individual route's BGP details. Newer versions of EOS (Confirmed on 4.20.7M) do not allow simultaneous use of the longer-prefixes and detail modifers for "show ip bgp", so detect this and fall back, resulting in lost peer addresses for the routes. Since this only occurs when `longer` is True, it should be OK until the vendor addresses the behavior change from 4.19 to 4.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
baseandeosdrivers to support returning more specific prefixes inget_route_to()Raise NotImplementedError on drivers that implement
get_route_to()when kwarglongerisTrue