Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: napari crashed because of type names #29

Merged
merged 1 commit into from
May 9, 2021
Merged

Bugfix: napari crashed because of type names #29

merged 1 commit into from
May 9, 2021

Conversation

haesleinhuepf
Copy link
Contributor

@haesleinhuepf haesleinhuepf commented May 9, 2021 •
edited
Loading

Hi @tlambert03

as you suspected, this fixes and closes #28

Thanks for the hint!

Cheers,
Robert

tlambert03
tlambert03 approved these changes May 9, 2021
View reviewed changes
Copy link
Contributor

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Yeah... I've recently been realizing just how difficult ForwardRef type hints can be. I think we might be able to fix this either in magicgui or in napari proper, but this will always be a "safe" way to do it.

@tlambert03 tlambert03 merged commit 791596f into napari:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlambert03 tlambert03 tlambert03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Napari crashes in freshly created plugins when selecting a function widget form the menu
2 participants
@haesleinhuepf @tlambert03