Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump min magicgui version to 0.7.0 #6454

Closed
lucyleeow opened this issue Nov 15, 2023 · 2 comments 路 Fixed by #6462
Closed

Bump min magicgui version to 0.7.0 #6454

lucyleeow opened this issue Nov 15, 2023 · 2 comments 路 Fixed by #6462
Labels
task

Comments

@lucyleeow
Copy link
Contributor

lucyleeow commented Nov 15, 2023 •
edited
Loading

馃О Task

I think magicgui.type_map module was created in pyapp-kit/magicgui#497 (with files moved from magicgui/ to magicgui/type_maps/), which was added in version 0.7.0.

Types such as MagicFactory now live in magicgui.type_map._magicgui.MagicFactory. Can we bump min magicgui version so we can import these?

Note, for our CIs:

Looks like in the requirements we list magicgui>=0.3.6 which, for headless tests, gives us magicgui==0.3.6 but for others, it gives us magicgui==0.8.0 (possibly because we depend on something else that's bumped the requirement for magicgui?

ref: #4991 (comment)
@lucyleeow lucyleeow added the task label Nov 15, 2023
@lucyleeow
Copy link
Contributor Author

cc @DragaDoncila @Czaki

@lucyleeow lucyleeow mentioned this issue Nov 15, 2023
Merged
@Czaki
Copy link
Collaborator

Czaki commented Nov 15, 2023

yes

@lucyleeow lucyleeow mentioned this issue Nov 16, 2023
Merged
Carreau pushed a commit that referenced this issue Nov 21, 2023
@lucyleeow
MAINT Bump magicgui version to v0.7.0 (#6462)
a48136f 
* Bump magicgui version to v0.7.0, where the `magicgui.type_map` module
was introduced
* Remove old code that accommodated for magicgui < 0.2.6 (note we
currently import `magicgui.widgets.FunctionGui` in other files)
* also bumped binder magicgui version
* bump psygnal to 0.5.0

closes #6454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT Bump magicgui version to v0.7.0 lucyleeow/napari
2 participants
@Czaki @lucyleeow