Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: repo reorganization and return removed names #497

Merged
merged 13 commits into from
Nov 13, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 12, 2022

The goal of this reorganization is to make clearer top-level modules that delineate the main components of magicgui

Screen Shot 2022-11-13 at 8 55 02 AM

There are a lot of changes here, but I have tested both napari and magic-class to make sure that everything still passes (albeit with some warnings), and opened napari/napari#5331 to remove one of those warnings

This also returns some of the names removed in #448 and #475 (to get magic-class tests working again)

@tlambert03
Copy link
Member Author

tests will pass here after napari/napari#5331

@tlambert03 tlambert03 changed the title refactor: reorganize some modules and return removed names refactor: repo reorganization and return removed names Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 90.17% // Head: 89.66% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (c25f18c) compared to base (3c0c49b).
Patch coverage: 91.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   90.17%   89.66%   -0.52%     
==========================================
  Files          32       34       +2     
  Lines        4224     4237      +13     
==========================================
- Hits         3809     3799      -10     
- Misses        415      438      +23     
Impacted Files Coverage Δ
magicgui/widgets/protocols.py 100.00% <ø> (ø)
magicgui/types.py 87.17% <50.00%> (-6.76%) ⬇️
magicgui/type_map/__init__.py 58.33% <58.33%> (ø)
magicgui/widgets/bases/_widget.py 87.93% <87.93%> (ø)
magicgui/widgets/bases/_value_widget.py 98.33% <98.33%> (ø)
magicgui/_util.py 63.38% <100.00%> (+2.77%) ⬆️
magicgui/backends/_ipynb/application.py 90.90% <100.00%> (ø)
magicgui/backends/_ipynb/widgets.py 64.25% <100.00%> (ø)
magicgui/backends/_qtpy/application.py 100.00% <100.00%> (ø)
magicgui/backends/_qtpy/widgets.py 87.87% <100.00%> (-0.02%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant