Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-ups for all sliders #879

Open
sofroniewn opened this issue Jan 14, 2020 · 6 comments
Open

Pop-ups for all sliders #879

sofroniewn opened this issue Jan 14, 2020 · 6 comments
Assignees
Labels
design Design discussion feature New feature or request qt Relates to qt
Milestone

Comments

@sofroniewn
Copy link
Contributor

馃殌 Feature

Now that we have #837 in and #869 about to go in, I'd like to revisit this #837 (comment)

Also would be nice to add similar pop up / edit labels / range control for our single sliders too - in which case having one number above the slider is the natural generalization

This would be particularly useful for things like the point size slider where the upper end of the slider range was picked pretty arbitrarily

For things like opacity it鈥檚 still nice to expand so you can type in a direct value, but there maybe we shouldn鈥檛 allow the range ends to be editable as 0, 1 is the natural choice

Maybe for point size only the upper range is editable as 0 is the natural minimum, or maybe it鈥檚 more appropriate to think of absolute bounds that you can鈥檛 edit beyond

What do you think @tlambert03? There are two main reasons I like this idea - one is functionality - it will let people type in values, see values, and adjust ranges for all our sliders

  • second is that it then provides uniformity and standardization to the UI experience. For example, now I imagine people might right click on our other sliders (in the control panels) and expect similar behavior
@sofroniewn sofroniewn added the feature New feature or request label Jan 14, 2020
@sofroniewn sofroniewn added this to the 0.2.11 milestone Jan 14, 2020
@AhmetCanSolak
Copy link
Contributor

I like the uniformity on our sliders. If @tlambert03 is busy with other stuff i will be interested in picking this up. As @sofroniewn said it is nice to be able to just type the exact value for slider position.

@tlambert03
Copy link
Member

Fine with me @AhmetCanSolak! I've got a lot of open PRs at the moment and a busy couple weeks... go for it and let me know if I can be of help

@sofroniewn
Copy link
Contributor Author

Thanks for volunteering @AhmetCanSolak - now that #869 is in you can start on this when you like. You might want to look at this #869 (comment) too before you start, it could be helpful if you want to adjust the vertical alignment (not orientation) of the sliders:

One comment @tlambert03 - that can wait for future PRs - but if we like the ideas in #879 we might want to make the slider popup be vertically aligned with the slider your clicking on instead of with the top of the viewer.

If @AhmetCanSolak wants to play with that idea in #879, I would suggest starting with the QtPopup.show_above_mouse function. That function should probably be modified to a more general show_relative_to_position function that accepts a QPoint as an argument (rather than just always defaulting to QCursor.pos(), and making that point the clicked widget would accomplish this behavior.

@AhmetCanSolak
Copy link
Contributor

Thanks for heads up @sofroniewn !

@sofroniewn sofroniewn modified the milestones: 0.2.11, 0.2.12 Jan 28, 2020
@sofroniewn sofroniewn modified the milestones: 0.2.12, 0.2.13 Feb 23, 2020
@tlambert03 tlambert03 removed their assignment Mar 7, 2020
@sofroniewn sofroniewn modified the milestones: 0.3.0, 0.3.1 Apr 21, 2020
@sofroniewn sofroniewn modified the milestones: 0.3.1, 0.3 May 9, 2020
@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/pixel-is-not-a-square/39455/4

@sofroniewn sofroniewn added the design Design discussion label Jun 25, 2020
@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/missing-features/41518/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design discussion feature New feature or request qt Relates to qt
Projects
None yet
Development

No branches or pull requests

4 participants