Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_points_with_properties example #1126

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

kevinyamauchi
Copy link
Contributor

Description

This PR fixes the points with properties example. The point toggling in add_points_with_properties.py was broken by #1033 when Points.selected_data became a set.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

References

How has this been tested?

  • tested the example
  • all tests pass with my change

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #1126 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files         220      220           
  Lines       19379    19379           
=======================================
+ Hits        16856    16857    +1     
+ Misses       2523     2522    -1     
Impacted Files Coverage Δ
napari/conftest.py 96.55% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434d54e...82f29e1. Read the comment docs.

@sofroniewn sofroniewn added the bug Something isn't working label Apr 10, 2020
@sofroniewn sofroniewn added this to the 0.3.0 milestone Apr 10, 2020
Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching

@sofroniewn sofroniewn merged commit 391cfd5 into napari:master Apr 10, 2020
@kevinyamauchi
Copy link
Contributor Author

@adamltyson, I just wanted to put this on your radar in case you are still using this functionality. Points.selected_data will be changed from a list to a set in the next release, so you may need to update how you are slicing/indexing if you're using Points.selected_data to interact with your data (e.g., properties/annotations). I hope all is well!

@adamltyson
Copy link

Thanks for the heads up @kevinyamauchi. I am using Points.selected_data, so I'll update my code.

Thanks again for adding this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants