Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to upload pytest json report as artifact. #4518

Merged
merged 3 commits into from
May 28, 2022
Merged

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented May 12, 2022

Mostly I want to investigate why tests are taking forever on CI,
like up to 45 minutes. It's hard with just printing the slowest 10
durations, as this may be dues to some test having for example many
parameters.

With this I should be able to download the artifact and analyse them.

Mostly I want to investigate why tests are taking forever on CI,
like up to 45 minutes. It's hard with just printing the slowest 10
durations, as this may be dues to some test having for example many
parameters.

With this I should be able to download the artifact and analyse them.
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #4518 (cef5e69) into main (580ddda) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4518   +/-   ##
=======================================
  Coverage   84.39%   84.40%           
=======================================
  Files         607      607           
  Lines       51179    51179           
=======================================
+ Hits        43195    43196    +1     
+ Misses       7984     7983    -1     
Impacted Files Coverage Δ
napari/utils/action_manager.py 84.11% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580ddda...cef5e69. Read the comment docs.

@Carreau
Copy link
Contributor Author

Carreau commented May 12, 2022

The goal being to create something like the following (interactive), that show us which groups of test(s) potentially across platforms are taking the most time.
Screen Shot 2022-05-12 at 17 07 21

Here we see that likely we want to optimise test_add_layer, and zooming in show us that most of the time is spent there because of the large number of parameters:

Screen Shot 2022-05-12 at 17 10 08

@Carreau
Copy link
Contributor Author

Carreau commented May 13, 2022

This allowed me to find #4521 that greatly speedup the test suite.

@Carreau
Copy link
Contributor Author

Carreau commented May 13, 2022

To try, you can head to the test suite summary, download the artifacts.
And drag and drop the resulting files on this page:

https://carreau.github.io/pytest-json-report-viewer/

You will get a breakdown you can explore.

@Carreau Carreau merged commit 681b270 into napari:main May 28, 2022
@Carreau
Copy link
Contributor Author

Carreau commented May 28, 2022

Self merging again, we can refine later.

@Carreau Carreau added this to the 0.4.16 milestone May 31, 2022
@Czaki Czaki mentioned this pull request Jun 7, 2022
12 tasks
@Czaki Czaki modified the milestones: 0.4.16, 0.4.17 Sep 11, 2022
@Carreau Carreau deleted the jsonupload branch October 2, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants